Fix overlapping Google Calendar event lanes#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Google Calendar blockers on the planner timeline when multiple synced events share the same time range, and tightens the hide/sync behavior around those blockers.
X Hidecontrol pinned to the top-right corner, matching the full-width card layout while reserving space so title/time text truncates cleanly.Sync calendarrestores hidden Google blockers from the fresh sync, while automatic syncs continue respecting local hides.restoreHiddenquery flag so manual and background syncs can intentionally differ.Changes
timeline-board.tsx- computes visible calendar-event overlap lanes and passes lane placement into each event card.timeline-board-calendar-event.tsx- applies lane-based left/width styles and pins shared-lane Hide controls to the top-right.timeline-board.test.tsx- adds regression coverage for three simultaneous synced events and top-right Hide controls.planner-service-calendar.ts/ planner route/service/client wiring - preserves dismissal markers for background sync and clears them only for explicit restore syncs.day-plan.ts- adds the sharedcalendarSyncQuerySchemafor the new sync option.Test plan
corepack pnpm --filter @timefraim/web test -- src/components/timeline-board.test.tsxcorepack pnpm --filter @timefraim/server test -- src/services/planner-service.test.tscorepack pnpm --filter @timefraim/web test -- src/hooks/use-planner-mutations.test.tsx src/hooks/use-auto-google-task-sync.test.tsxcorepack pnpm --filter @timefraim/shared test -- src/index.test.tscorepack pnpm lintcorepack pnpm typecheckgit diff --checkCreated by Codex